Add preview page edit functionality

[ikisler]

Added a new action, preview_edit, and made some changes in the edit action so they'd work together.

Resolves Preview changes #59

I had attempted to use the Windows batch file to create the proper index, and etc., but it wasn't working for me. Wound up making a quick adjustment to pack.php and running build.php from the browser. I committed all the files changed -- hopefully that is correct?

Let me know if any changes are needed. :3

[ikisler]

Oh shoot. I just realized that I named the new action with an underbar, rather than a dash like the other multi-word actions... I will fix after work tomorrow. I obviously need to go to bed for now. xP

[ikisler]

Thank you for the feedback! I will go through these in more detail later today and update where needed.

[sbrl]

Sounds good! Just comment again here once you're done :smiley_cat:

And don't worry about the conflicts - I'll sort them out myself once you're done tweaking :wink:

[ikisler]

Okay, I think I've addressed everything?

Please take a look and let me know if I need to make additional changes. =D

[sbrl]

I've just taken a look. It works well - I like it! I've got a few more niggles though:

• The save button should be on the right, not the left (English is left-to-right, and you'll want to preview it before saving, not the other way around)
• The message should read something more like "This is only a preview, so your edits haven't been saved! Scroll down to continue editing.", as having an ellipsis there doesn't feel right.

Sorry for all the niggles! I'm rather picky as I've been working on this thing for a while :P

[ikisler]

Finally got time to look at this again! Rearranged the save and preview buttons, and changed the preview warning message content, and also moved it to it's own class rather than an H4.

Don't worry about being picky -- software development is all in the details.

[sbrl]

@ikisler Awesome~! Thanks for the additions. And yes - it certainly according to my (limited) experience so far. I'll just take a final look. 2 last issues:

• You seem to have updated the css, but not the preview message (it's still got the old text from what I can see here in a <h4>)
• I'm not sure where, but somewhere along the line I think one of your commits fiddled with the linux file permissions on the files in this repository. It's not an issue though - I can sort them out in a separate commit after merging.

[ikisler]

Augh, how did I do that? >.< The preview message is actually updated now.

I probably broke the linux file permissions because I'm doing development on a Windows machine? I'm not sure how to prevent that from happening again, though -- will do some reading and see what can be done about it.

[sbrl]

Thanks for the fixes! Let's see about a final test, and then a merge :smile_cat:

[sbrl]

First manual merge complete! Thanks for the contribution, @ikisler. I'll add you to the credits!

[sbrl]

Turns out at least some of those permissions issues were actually my fault too - they were left over from when I was dual-booting & had my code repos on an NTFS partition :P

I've cleaned them up now anyway :D

[sbrl]

I've found a small bug - if you preview a page that isn't the main page, the page GET parameter is not set correctly such that it think you're editing the main page after clicking preview. I'm fixing it now.

[ikisler]

Yay, thanks so much! =D

[sbrl]

@ikisler Np! It's been a fun process for me, too - especially because it was my first pull request from someone else against any of my projects :smiley_cat:

Oh and v0.14 beta 1 is out! If there aren't any bugs, I'll probably do a full release on Friday.