search

sbrl / Pepperminty-Wiki

A wiki in a box
https://peppermint.mooncarrot.space/
Mozilla Public License 2.0
178 stars 20 forks source link

build.sh Fails #177

Closed lbonanomi closed 4 years ago

lbonanomi commented 4 years ago

Its a snippy little complaint, but this line of the build script is always going to fail on an initial clone.

Example: 

# ./build.sh setup
./build.sh: line 28: ./lantern-build-engine/lantern.sh: No such file or directory

Would you consider testing as [ ! -x "${lantern_path}/lantern.sh" ]; instead?

sbrl commented 4 years ago

Oh, my! Thanks for pointing that out. I've actually fixed that in other projects that use lantern. I'll fix it here too.

sbrl commented 4 years ago

Erm taking a look at it, I notice that I've already applied the fix: https://github.com/sbrl/Pepperminty-Wiki/blob/05615b4c81712a29e87e014893fbc02fc8aaa615/build.sh#L26

Are you using the latest version, @lbonanomi?

lbonanomi commented 4 years ago

@sbrl I'm working with a hot-off-the-press copy, but using a vanilla git clone which creates an empty dir for a submodule. Not sure if this is a better job for a code fix or a behavior change for the would-be user.

git clone --recurse-submodules https://github.com/sbrl/Pepperminty-Wiki.git is confirmed to get the goods.

sbrl commented 4 years ago

Ahhhh I see. I'll fix that check right away then.

sbrl commented 4 years ago

Done :-)