sbrl / Pepperminty-Wiki

A wiki in a box
https://peppermint.mooncarrot.space/
Mozilla Public License 2.0
178 stars 20 forks source link

build.sh looks for NPM twice #178

Closed lbonanomi closed 4 years ago

lbonanomi commented 4 years ago

build.sh looks for "npm" twice, was this intended to check for PHP as-well?

If it was meant to check for PHP, could the check be either supplemented by or replaced with a test of php -m | grep -q intl? I'm working with the rh-php73 RPM right now, which doesn't install the intl extension by default and left me with a scary error message.

sbrl commented 4 years ago

Great catch - I suspect you're right. Note that the documentation lists the PHP modules you need to have installed.

Note also that I've recently upgraded to PHP 7.4 in my development environment, and as a result I've squashed a number of issues generating warnings (and a crash!) when using PHP 7.4 just yesterday.

I'll look at adding that test for modules too - thanks :-)

sbrl commented 4 years ago

Fixed! :D