sbromberger / LightGraphs.jl

An optimized graphs package for the Julia programming language
Other
672 stars 184 forks source link

Set of dependency versions that work on 0.6 #559

Closed jpfairbanks closed 7 years ago

jpfairbanks commented 7 years ago

Is there a set of dependency versions that we need to be using for testing on 0.6 without errors or warnings?

sbromberger commented 7 years ago

Good question. I'm using the latest versions. I was just going to require the latest of everything before tagging.

jpfairbanks commented 7 years ago

I am getting a lot of warnings from ParserCombinator.

sbromberger commented 7 years ago

Yup. They're still using tasks :)

jpfairbanks commented 7 years ago

I also got an error from GZIP even though I am on master of that package.

sbromberger commented 7 years ago

error, or warning? Paste here?

I'm using v"0.3.0"

sbromberger commented 7 years ago

ah, the reason I'm not seeing the warnings anymore is because the code is already compiled. When I delete the .ji files I see them again.

Most of these deal with persistence.

https://gist.github.com/sbromberger/001fc06ca807b6d83bac5ded7067933c

jpfairbanks commented 7 years ago

julia> Pkg.test("LightGraphs")
INFO: Testing LightGraphs
Test Summary: | Pass  Total
Interface     |   22     22
Test Summary: | Pass  Total
Core          |  107    107
Test Summary: | Pass  Total
SimpleGraphs  |  211    211
Test Summary:  | Pass  Total
SimpleEdgeIter |   20     20
Test Summary: | Pass  Total
Operators     |  237    237
Test Summary: | Pass  Total
Distance      |   38     38
Test Summary: | Pass  Total
Edit distance |  240    240
Test Summary: | Pass  Total
Spectral      |  285    285
Test Summary:  | Pass  Total
Graph matrices |   89     89
Test Summary: | Pass  Total
Connectivity  |  244    244
Test Summary: | Pass  Total
Transitivity  |   24     24
Persistence: Error During Test
  Got an exception of type UndefVarError outside of a @test
  UndefVarError: readall not defined
  Stacktrace:
   [1] loadgraphml_mult(::GZip.GZipStream) at /home/name/.julia/v0.6/LightGraphs/src/persistence/graphml.jl:54
   [2] load(::GZip.GZipStream, ::Symbol) at /home/name/.julia/v0.6/LightGraphs/src/persistence/common.jl:54
   [3] gzopen(::LightGraphs.##77#78{Tuple{Symbol}}, ::String, ::String) at /home/name/.julia/v0.6/GZip/src/GZip.jl:268
   [4] open(::Function, ::Vararg{Any,N} where N) at /home/name/.julia/v0.6/GZip/src/GZip.jl:264
   [5] macro expansion at /home/name/.julia/v0.6/LightGraphs/test/persistence/persistence.jl:48 [inlined]
   [6] macro expansion at ./test.jl:853 [inlined]
   [7] anonymous at ./<missing>:?
   [8] include_from_node1(::String) at ./loading.jl:539
   [9] include(::String) at ./sysimg.jl:14
   [10] macro expansion at /home/name/.julia/v0.6/LightGraphs/test/runtests.jl:100 [inlined]
   [11] anonymous at ./<missing>:?
   [12] include_from_node1(::String) at ./loading.jl:539
   [13] include(::String) at ./sysimg.jl:14
   [14] process_options(::Base.JLOptions) at ./client.jl:305
   [15] _start() at ./client.jl:371
sbromberger commented 7 years ago

Move to v0.3.0

jpfairbanks commented 7 years ago

Of Gzip?

sbromberger commented 7 years ago

Yeah, wait. Now I'm getting that error.

sbromberger commented 7 years ago

Just fixed the readall issue - new pull available.

sbromberger commented 7 years ago

For 1.1.0, modify REQUIRES so that versions of deps don't throw warnings / are built for 0.6.0

sbromberger commented 7 years ago

Closing this out because of The Lightening(tm), but we still need to bump dependency versions at some point.