search

sbromberger / SimpleWeightedGraphs.jl

Simple weighted graphs. Requires LightGraphs.jl.
Other
49 stars 22 forks source link

Fix adjacency & Laplacian matrices for weighted graph #48

Closed yuehhua closed 4 years ago

sbromberger commented 4 years ago

I had to fix .travis.yml. Could you merge master into this PR and let it retest?

codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will decrease coverage by 0.84%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   92.98%   92.14%   -0.85%     
==========================================
  Files           6        6              
  Lines         271      242      -29     
==========================================
- Hits          252      223      -29     
  Misses         19       19
Impacted Files Coverage Δ
src/SimpleWeightedGraphs.jl 90% <ø> (-1.43%) :arrow_down:
src/overrides.jl 98.14% <100%> (-0.29%) :arrow_down:
src/simpleweightedgraph.jl 84.09% <0%> (-1.02%) :arrow_down:
src/simpleweighteddigraph.jl 87.8% <0%> (-0.57%) :arrow_down:
src/persistence.jl 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 379adf6...2154b20. Read the comment docs.

yuehhua commented 4 years ago

@sbromberger Is it good?

sbromberger commented 4 years ago

We need more tests to get the test coverage up. Once that's done it'll be ready for final review and merge.

yuehhua commented 4 years ago

Done.

sbromberger commented 4 years ago

awesome. Thanks!