search

sbruder / spectral

Port of html5up’s spectral theme to hugo
Other
75 stars 46 forks source link

port FontAwesome to v6.x #21

Closed richarvey closed 1 year ago

richarvey commented 1 year ago

Upgraded fontawesome to v6.x and added a few extra options for social links, including GitHub, mastodon and youtube.

dholbach commented 1 year ago

Thanks a lot for your work and the PR! I left a couple of questions to understand the changes better.

dholbach commented 1 year ago

@richarvey I just pushed a commit to this PR which rolls back some of the (to me) seemingly unrelated changes. Does that still look OK to you?

@sbruder Do you have any thoughts on this? In my local tests, this all seems to look and work fine.

dholbach commented 1 year ago 
assets/css/main.css:@import url(font-awesome.min.css);

Should this be fontawesome-all.min.css instead?

dholbach commented 1 year ago 
assets/css/main.css:@import url(font-awesome.min.css);

Should this be fontawesome-all.min.css instead?

I made this change now.