search

sbruder / spectral

Port of html5up’s spectral theme to hugo
Other
63 stars 42 forks source link

Update theme.toml with values from new template #7

Closed dholbach closed 2 years ago

dholbach commented 2 years ago

Signed-off-by: Daniel Holbach daniel@holba.ch

dholbach commented 2 years ago

In order to resolve #4, we'll need to add some screenshots - @sbruder are you fine if I take them from kegelschiene.net?

sbruder commented 2 years ago

I’m not sure if that is wanted for https://themes.gohugo.io. While looking at some example screenshots, they all seemed to showcase dummy content (most likely their exampleSite). Maybe the example site could be modified to showcase more of the theme. Also, the exampleSite currently is somewhat broken (the paragraphs on the front page are on the same line as the headings, see #8)

dholbach commented 2 years ago

That makes sense - I'll take a look at what could be modified to showcase more of the theme.

dholbach commented 2 years ago

I updated the images to be about the exampleSite and made it so it reflects all config.toml values that are configurable. In a next revision we could look into adding some more meaningful content - or re-use some of the standard hugo content that everybody uses in themes.

dholbach commented 2 years ago

I didn’t find a way to leave inline feedback for the images: The Hugo theme guidlines specify that the screenshots should have an aspect ratio of 3:2. I took one that fits the requirements, generated a 900×600 thumbnail and optimised them losslessly with oxipng-s -o 3: screenshot.png tn.png

Thanks a lot - I wasn't aware of oxipng looks useful! I used your images.

dholbach commented 2 years ago

Besides that, this looks good.

Good catch!