sbryfcz / harmony-card

A Home Assistant Lovelace Care for Harmony Integration
MIT License
104 stars 12 forks source link

need help building #39

Closed ItzYanick closed 3 years ago

ItzYanick commented 3 years ago

I just downloaded your repository and wanted to build it. But as soon as i hit enter, nodejs spits out like 600 errors on eslint (not even a joke. it shows 681 errors). Maybe someone can help me out here.

sbryfcz commented 3 years ago

Yeah. I'm not sure what is going on. Please try to ignore the lint errors as they are plentiful (and frankly I never had a goal to stay in line with the lining guidelines I got the boilerplate starter code from). I typically run npm run start and point my local HA instance to that served up file while debugging.

ItzYanick commented 3 years ago

okay i just tried using npm run start and run into another issue: now it shows me following error: [!] (plugin rpt2) Error: /home/yanick/Documents/Projects/harmony-card/src/harmony-card.ts(80,19): syntax error TS1109: Expression expected. maybe you have a quick fix or workaround for this one too

sbryfcz commented 3 years ago

Hmmmmm that's an odd one. I was JUST doing a bit of work on this and it compiled and started up great. What version of non are you running? I assume you ran an npm install first.

ItzYanick commented 3 years ago

Of course i ran npm install haha. I first tested it on node v14.14.0 but when i saw you were using node v8 (as written in the readme file) i installed v8.17.0 and there was the same issue

ItzYanick commented 3 years ago

Okay i just delete node_modules and reinstalled it. Now i got a other error [!] (plugin rpt2) Error: /home/yanick/Documents/Projects/harmony-card/src/harmony-card.ts(166,13): semantic error TS2345: Argument of type '{ hasHold: boolean; hasDoubleTap: boolean; repeat: number | undefined; }' is not assignable to parameter of type 'ActionHandlerOptions'. Object literal may only specify known properties, and 'hasDoubleTap' does not exist in type 'ActionHandlerOptions'.

sbryfcz commented 3 years ago

Hmmmm. I'll try to investigate.

ItzYanick commented 3 years ago

Okay. Thank you very very much then already 🙏 Hope you can find out whats going wrong here haha

sbryfcz commented 3 years ago

Hmmmmm. I wiped out my node_modules and dist folders. Then I ran npm install followed by npm run start. Everything compiled fine for me.....

Not sure it matters but here are my current npm and node versions

$ npm -v 6.14.7

$ node -v v10.15.3

ItzYanick commented 3 years ago

could you paste your package-lock.json onto pastebin and then on here maybe? Maybe i can find something comparing mine with yours.

sbryfcz commented 3 years ago

Just pushed it to master....thought it was already there. Hope that helps.

ItzYanick commented 3 years ago

IT WORKED! I just swapped out my package-lock.json file with yours. Then i just ran npm install and now it works hahaha It seems your package.json in the repo is not equal to your local installation with your package-lock.json

ItzYanick commented 3 years ago

So I made a fork of your repo and added a numpad / keypad for this card. I saw there is an open issue facing that. If you want I can document the new settings and make a pull request so that you can add it to the code if you like :D

sbryfcz commented 3 years ago

That would be great! I was just working on similar. Would love to see what you came up with.


From: Yanick notifications@github.com Sent: Thursday, October 22, 2020 4:19:16 PM To: sbryfcz/harmony-card harmony-card@noreply.github.com Cc: Sam Bryfczynski sbryfcz@gmail.com; Comment comment@noreply.github.com Subject: Re: [sbryfcz/harmony-card] need help building (#39)

So I made a fork of your repo and added a numpad / keypad for this card. I saw there is an open issue facing that. If you want I can document the new settings and make a pull request so that you can add it to the code if you like :D

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/sbryfcz/harmony-card/issues/39#issuecomment-714737724, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA2AOQKN5VJECROVVF7VMJLSMCHUJANCNFSM4S3MED4Q.