Packaging improvements - Githubissues

chayleaf commented 7 months ago

(see #695)

partially fixes #629 (the initial config is built before loading user options, so the initial config still uses convert from PATH)

This fixes what I consider not following the best packaging practices. Namely:

State and resources should be decoupled. Currently, they aren't - the package expects data and config in its directory, even if those are symlinks. Best practice is for any paths to runtime state to be completely decoupled from whatever is in /usr.
Config path should be configurable. This ensures testing is easy without editing /etc, you can even run multiple instances of the software with different options. Currently it's hacked upon with config symlink, which is a very bad solution.
The app should work fine when started with an empty state directory. Currently, it expects preview/default.jpg to exist there.

chayleaf commented 7 months ago

I've now verified that this works (except the Debian package) and am running this version

chayleaf commented 7 months ago

tests/lints pass on all commits now, and I've separated the changes into commits a bit better

sbs20 commented 7 months ago

Thanks for this! There's a lot to review here. I will get to it when I can.

sbs20 / scanservjs