sbsdev / daisyproducer2

An integrated production management system for accessible media
GNU Affero General Public License v3.0
0 stars 0 forks source link

Ignore flag #98

Closed egli closed 4 months ago

egli commented 3 years ago

Add an isIgnored flag to the dictionary_unknownword table. The query to fetch the unknown words then orders by this flag and hence shows the ignored words last. Everything basically works (db model, queries, Clojure backend code, API end point and Clojurescript UI).

However there is a problem because while you can mark an unknown word as ignored this fact is ignored because each request for unknown words currently wipes the dictionary_unknownword table clean and hence drops any information about ignored words.

To fix this we would probably have to update the dictionary_unknownword only when uploading a new version of a document and enhance the query to get all unknown words to only join with the unknown words for the given document_id.

TBH I'm not quite sure anymore what the motivation was behind the decision to wipe the dictionary_unknownword table for each request.