fix write setup overwriting read setup.

sbstjn / serverless-dynamodb-autoscaling

Serverless Plugin for Amazon DynamoDB Auto Scaling configuration.

https://sbstjn.com/serverless-dynamodb-auto-scaling-with-cloudformation.html

MIT License

148 stars 27 forks source link

fix write setup overwriting read setup. #22

Closed tmclaugh closed 7 years ago

tmclaugh commented 7 years ago

Solves two issues

only read values were being used.
Write CFN resources overwrote the read resources.

Not familiar enough with TypeScript / JavaScript to know if there's more to be done.

hotgazpacho commented 7 years ago

Interesting, I just ran into this as well. Was wondering why my tables were being created with only write scaling...

sbstjn commented 7 years ago

Good catch, sorry for adding this bug with the last refactoring :)

tmclaugh commented 7 years ago

Anything I can do to speed up merge of this? Just waiting on a personal project for work.

sbstjn commented 7 years ago

I just merged it and triggered a deployment for version v0.6.1. It should be on NPM in a few minutes. Thanks for your contribution! Feedback would be appreciated if the new version works fine.