search

sbstjn / sqs-worker-serverless

Example for SQS Worker in AWS Lambda using Serverless
https://sbstjn.com/serverless-sqs-worker-with-aws-lambda.html
MIT License
179 stars 38 forks source link

Scale up Cloudwatch Alarm Regex typo #2

Open lucasklaassen opened 6 years ago

lucasklaassen commented 6 years ago

Hey man, thanks for putting this together! I love how it works.

Just noticed when I tried to port this to my project that the scale up Cloudwatch alarm regex has a typo: https://github.com/sbstjn/sqs-worker-serverless/blob/master/functions/scale.js#L7

The Cloudwatch alarms that were set up for me had Message being singular instead of plural.

Maybe I misconfigured something but I believe we should update:

 const regex = /(OK|ALARM):(.*)MessagesAlarm([0-9]*)/g

to 

 const regex = /(OK|ALARM):(.*)MessageAlarm([0-9]*)/g
oanabotezat commented 6 years ago

the test has to be updated as well. many many thanks for this example.

lucasklaassen commented 6 years ago

@oanabotezat Added PR with test updates, thanks for the comment!

lucasklaassen commented 6 years ago

@sbstjn any issues with PR on this one?