Replace xml-rs amd xmltree with quick-xml

sbstp / rust-igd

Internet Gateway Device (UPNP) client

https://docs.rs/igd/

MIT License

105 stars 43 forks source link

Replace xml-rs amd xmltree with quick-xml #34

Closed tafia closed 5 years ago

tafia commented 6 years ago

This PR replaces all instance of xml-rs and xmltree with (lower level) quick-xml.

I couldn't find any benchmark but it is supposed to be faster / use less memory. On the other hand, it might be more complicated to read (in particular the xmltree replacement).

No offense taken if you prefer NOT to merge it. This is just a proposal.

If someone has a realistic scenario to test, I would be happy to add a benchmark.

sbstp commented 5 years ago

I'll close this because I've just refactored everything. Also xmltree is easier to use and performance is not a primary need of this library.

tafia commented 5 years ago

Sure no problem!