search

sbstp / rust-igd

Internet Gateway Device (UPNP) client
https://docs.rs/igd/
MIT License
105 stars 43 forks source link

Implement GetGenericPortMappingEntry function #43

Closed maufl closed 4 years ago

maufl commented 4 years ago

I implemented the required functions for the GetGenericPortMappingEntry function. I'm not sure whether the new PortMappingEntry struct is a good idea as a return value, or whether all fields are ok (lease_duration could for example be a Duration).

This branch is based on the branch of my other PR, so I'd hold of reviewing it for now.

sbstp commented 4 years ago

Thanks for the other MR! Do you want to rebase this branch on master and then I'll merge & release?

maufl commented 4 years ago

Done. Do you think introducing the PortMappingEntry struct is a good idea?

sbstp commented 4 years ago

Done. Do you think introducing the PortMappingEntry struct is a good idea?

Sure, I don't see any issues with it.

maufl commented 4 years ago

Then I think you can merge it.