search

sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

fail "merging/merging" scripted test in travis-ci since December 2018 #356

Closed xuwei-k closed 5 years ago

xuwei-k commented 5 years ago

🤔

https://travis-ci.org/sbt/sbt-assembly/jobs/478647768#L882

[info] [error] java.lang.Exception: file /tmp/sbt_419bffc2/a had wrong content:
[info] [error] 2
[info] [error] 1
[info] [error] 3
[info] [error] 1
[info] [error] *** instead of ***
[info] [error] 1
[info] [error] 2
[info] [error] 1
[info] [error] 3
[info] [error]  at $94426f8c8ad71399f0ed$.mustContain(build.sbt:48)
[info] [error]  at $94426f8c8ad71399f0ed$.$anonfun$testmerge$7(build.sbt:21)
[info] [error]  at $94426f8c8ad71399f0ed$.$anonfun$testmerge$7$adapted(build.sbt:19)
[info] [error]  at sbt.io.IO$.withTemporaryDirectory(IO.scala:475)

https://travis-ci.org/sbt/sbt-assembly/builds

travis-ci-build-logs

https://github.com/sbt/sbt-assembly/commits/master

master-branch-commit-log
xuwei-k commented 5 years ago

Some MergeStrategy does not treat order of Seq[File]. I think order depends on classpath order. (maybe classpath order depends on sbt internal implementations 🤔)

Should we sort classpath in here?

eed3si9n commented 5 years ago

I guess it makes sense to sort.