search

sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

fix(248): Shading randomly fails. #376

Closed eric-poitras closed 5 years ago

eric-poitras commented 5 years ago

Fixes #248

Fixed an issue to the Shader class that caused shading rules to fail being applied correctly. The issues looked random and behavior was different from one machine to the other. The issue was trigged when we started shading Multi-Release jars that contained classes files under META-INF.

The issue is from the reuse the EntryStruct from one call to the other. Once the flag skipTransform is set to true (By jarjar's MisplacedClassProcessor), the plugin stop applying the shading rule. The behavior looks random since it is affected by the order in which the files are processed.

The patch just make sure to reset the flag between each call.

eric-poitras commented 5 years ago

Hi @eed3si9n ! Is is possible to have a release with the fix ? That would be awesome.

eed3si9n commented 5 years ago

I'm on vacay now but hopefully I will have some time in a few days.

eed3si9n commented 5 years ago

https://discuss.lightbend.com/t/announce-sbt-assembly-1-14-10/4549