search

sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

Make readme less condencending. #417

Closed olafurpg closed 3 years ago

olafurpg commented 3 years ago

The old readme said "If you need to tell sbt-assembly to ignore JARs, you're probably doing it wrong" and then followed up with "If you Spark people want to use provided jars at runtime" which I think is unnecessarily condensending. The new readme tones it down by saying "If you're using Spark and want to ...".

eed3si9n commented 3 years ago

At the time when I wrote it I meant to be helpful since I thought it's a common issue among the Spark users who also use sbt-assembly for local testing. If it came off as condescending, that's my error and I'd be happy to accept this change.

olafurpg commented 3 years ago

Thank you for merging! It's nice that the docs mention this use-case for people using Spark, and I assumed it was written only with good intention. My primary gripe is that "you Spark people" can be interpreted as "Spark people are a different kind of people".