sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

scala-xml no longer part of core library in Scala-3... #467

Open DavidGoodenough opened 2 years ago

DavidGoodenough commented 2 years ago

but it is excluded by the includeScala=false directive as its file name starts with "scala-".

Unfortunately once excluded there appears to be no way to override the exclusion. So the logic that decided which .jar files to include when this option is used needs to be updated to use a better way of determining whether to include .jar content.

TimBloy commented 3 months ago

Hello, we've come across the same issue specifically for scala-xml. It appears the below check is flawed.

We're on Scala 3.3.1, so we would pass the >=2 check put fail the >=13 for the minor version.

https://github.com/sbt/sbt-assembly/blob/56f7e715ac3444237c8f1fd6c88abceeaf641e4a/src/main/scala/sbtassembly/Assembly.scala#L244-L249

As more users take on Scala 3.3 this will likely become more of an issue.

mzuehlke commented 3 months ago

As @TimBloy mentions the logic seems to predate Scala 3. The Scala 3 artifacts have even different names ("scala3-compiler" and "scala3-library")