search

sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

Run CI on Windows #471

Closed nightscape closed 2 years ago

nightscape commented 2 years ago

I'm noticing an error on Windows for 2.0.0-RC1 which was not there under 1.2.0 (will create a ticket for that). As a first step for fixing this it would be good if the CI discovered and exposed the error. I'm hoping that adding Windows to the build matrix already does so.

nightscape commented 2 years ago

@eed3si9n this PR would be ready to squash-merge from my side. It exposes the Windows bug in https://github.com/sbt/sbt-assembly/issues/472 What is not clear is if the Windows CI build would succeed if the bug was fixed. In order to test that, one would probably have to run the Windows CI against version 1.2.0 which is not affected by the bug. Any recommendations on how to proceed here?

eed3si9n commented 2 years ago

Any recommendations on how to proceed here?

I just created a branch called 1.x out of 1.2.0 - https://github.com/sbt/sbt-assembly/tree/1.x You could send another PR if you would like against it.

nightscape commented 2 years ago

Done in https://github.com/sbt/sbt-assembly/pull/473 Once that PR builds correctly on Windows, we can move on with this one here.

fnqista commented 2 years ago

Hey man,

I just wanna kindly follow up on a new release for sbt-assembly. Thanks in advance

On Wed, Oct 5, 2022 at 7:28 PM eugene yokota @.***> wrote:

Merged #471 https://github.com/sbt/sbt-assembly/pull/471 into develop.

— Reply to this email directly, view it on GitHub https://github.com/sbt/sbt-assembly/pull/471#event-7527121264, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRY7Q3GTRJM5F2YZAOSC3DWBW3DTANCNFSM5ZUPXL6Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>