sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

Run CI on Windows (1.x) #473

Open nightscape opened 2 years ago

nightscape commented 2 years ago

@eed3si9n the PR for the 1.x branch only has two errors. In the merging / merging test there are additional unexpected newlines. In sbt-assembly / piecemeal there's a java.lang.ClassNotFoundException: Main, potentially caused by java.lang.ClassNotFoundException: scala.Predef$. Would you have a pointer of what could be causing these?

fnqista commented 2 years ago

@nightscape It seems like even the 1.x version doesn't work on windows? Might be we need to fix more than what you mentioned in #472

nightscape commented 2 years ago

@fnqista yes, the two errors I mentioned above are unrelated to the Illegal character issue that I actually wanted to expose. Unfortunately I don't have much time left to dig into this, so I was hoping that one of the maintainers could help out or point me into the right direction.

fnqista commented 1 year ago

@nightscape I have had a chance to look at this (tbh I almost didn't want to because I dislike Windows development, but I am responsible for the 2.0 changes so I feel obligated to help):

Edit: There is another failure in 2.x, where we use System.getProperty(file.separator) for PathList.unapply, which we should not. We should just use / since every class file goes through the shader that converts all \ to /.

I can prepare a new PR with all the fixes for the above. Can you get Eugene to merge your PR first?

nightscape commented 1 year ago

@fnqista the other PR is merged 👍