Fix windows problems (#472)

fnqista commented 1 year ago

Based on Issue #472

Fixes for travis windows ci build

merging / merging fails in both in both 1.x and 2.x because we use System.getProperty(lineSeparator) and that causes the file to be written with CRLF endings in Windows. It can be fixed by using just \n
sbt-assembly / piecemeal fails in both in both 1.x and 2.x because of the wrong classpath syntax used by the jar runner in src/sbt-test/sbt-assembly/piecemeal/build.sbt. The separator for the classpath java -cp in Windows is ; instead of :
all other tests fail only in 2.x because of the error you reported in #472
There is another failure in 2.x, where we use System.getProperty(file.separator) for PathList.unapply, which we should not. We should just use / since every class file goes through the shader that converts all \ to /.

Note PR for including Windows in the Travis CI should be merged too

fnqista commented 1 year ago

@eed3si9n Perhaps a new release candidate, or release, when you have time?

eed3si9n commented 1 year ago

I think sufficient time has passed without any regressions, so I think we're good to go for the final.

fnqista commented 1 year ago

Thank you

On Mon, Oct 17, 2022 at 9:31 PM eugene yokota @.***> wrote:

I think sufficient time has passed without any regressions, so I think we're good to go for the final.

— Reply to this email directly, view it on GitHub https://github.com/sbt/sbt-assembly/pull/478#issuecomment-1281372502, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRY7Q2H54NQPLD3AA5MFG3WDWSR3ANCNFSM6AAAAAAQ4624OY . You are receiving this because you were mentioned.Message ID: @.***>

sbt / sbt-assembly

Fix windows problems (#472) #478