sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

feat: tag assembly task #485

Closed ingarabr closed 1 year ago

ingarabr commented 1 year ago

Add a tag for the assembly tasks. This can be used to restrict resource usages.

Why do we need this?

Version 2 of sbt-assembly uses more resources. This is problematic when executing assembly on a multi-module project causing different types of errors. I've encountered memory and to many open files issue. Adding a tag gives the user of the plugin the option to restrict concurrent executions with Global / concurrentRestrictions += Tags.limit(Assembly.assemblyTag, 1)

Things to consider

eed3si9n commented 1 year ago

Should the plugin have a default limit on the tag?

I think it's a good idea to put default limit on 1.

ingarabr commented 1 year ago

I agree that a default limit of 1 can be a good default. Please take a look at a04849b