sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

Concatenating files without a newline #489

Closed cpaika closed 1 year ago

cpaika commented 1 year ago

Using sbt-assembly 2.0.0 I've seen an issue on file concatenation - when one file does not have a newline at the end of it (in our case a HOCON reference.conf) the concatenated next file will not be concatenated with a newline, resulting in the contents being incorrect, example:

File1 (no newline):

akka.property = on

File2:

next-file-config{
  #more configuration

Result:

akka.property = onnext-file-config{
  #more configuration

Downgrading to sbt-assembly 1.2.0 fixed this issue so it feels like a regression since then.

eed3si9n commented 1 year ago

@cpaika Thanks for the report!

dragisak commented 1 year ago

482 is the fix for this

eed3si9n commented 1 year ago

O wow. Thanks for the reminder!

eed3si9n commented 1 year ago

The fix PR is merged, and released as 2.1.0.