sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.94k stars 223 forks source link

Add setting to allow adding arbitrary files to output Jar #491

Closed mdedetrich closed 1 year ago

mdedetrich commented 1 year ago

Context for this feature can be seen at https://github.com/apache/incubator-pekko/issues/140

In summary, the idea is to add a sbt setting (lets say assemblyIncludeFilesInJar) which has type Map[Set[java.io.File], sbt.io.Path]. This would mean that for each set of files. they would get added to the output Jar under the specific sbt.io.Path.

mdedetrich commented 1 year ago

Closing this, turns out that this feature is completely unnecessary since sbt-assembly should pick up files in resourcesManaged and due to a fairly bespoke usage/configuration of sbt-assembly that. we happen to be using, it wasn't dong this correctly (see https://github.com/apache/incubator-pekko/pull/174 for more info)