sbt / sbt-assembly

Deploy über-JARs. Restart processes. (port of codahale/assembly-sbt)
MIT License
1.95k stars 224 forks source link

Add an option to include files into output jar #493

Closed mdedetrich closed 1 year ago

mdedetrich commented 1 year ago

This is a PR that implements https://github.com/sbt/sbt-assembly/issues/491. PR is in a draft state since design might need to change and also need to verify if its actually neccessary.

mdedetrich commented 1 year ago

Closing this, turns out that this feature is completely unnecessary since sbt-assembly should pick up files in resourcesManaged and due to a fairly bespoke usage/configuration of sbt-assembly that. we happen to be using, it wasn't dong this correctly (see https://github.com/apache/incubator-pekko/pull/174 for more info)