search

sbt / sbt-atmos

sbt plugin for running Typesafe Console in development
98 stars 11 forks source link

An application started with `atmos:run` can't be stopped #6

Closed hseeberger closed 11 years ago

hseeberger commented 11 years ago

Using sbt-atmos 0.2.1 and Akka 2.2.0.

Check out this branch: https://github.com/typesafehub/training-akka-scala/tree/upgrade-to-atmos-0.2.1

Start sbt and enter atmos:run. Then create a "Guest" by entering g into the terminal. Then quit HakkyHour by entering q into the terminal.

The application is expected to exit and sbt should get back control, but that doesn't happen.

henrikengstrom commented 11 years ago

Thanks for pointing this out Heiko. We will address issue asap.

pvlugter commented 11 years ago

Doesn't exit as execution context tracer (future tracer) is global and uses non-daemon threads, while the actor tracer will shutdown along with the system. Daemon threads can be configured with:

atmos.trace.send.daemonic = true

I've published an sbt-atmos 0.2.2 with this as the default. And we'll make daemon threads the default for the global execution context tracer in atmos.

hseeberger commented 11 years ago

Works. Thanks!