search

sbt / sbt-boilerplate

sbt plugin for generating scala.Tuple/Function related boilerplate code
BSD 2-Clause "Simplified" License
109 stars 19 forks source link

Add support for the Test configuration #17

Closed nrinaudo closed 8 years ago

nrinaudo commented 8 years ago

As a side effect, the boilerplateSource setting is now exposed.

jrudolph commented 8 years ago

Thanks, @nrinaudo.

What's the reason to introduce boilerplateSource? AFAIK it is best practice to reuse settings where possible. If it is about reliably overriding default settings we should add an in Global instead.

jrudolph commented 8 years ago

Otherwise, this looks nice. Thanks also for modernizing sbt usage.

nrinaudo commented 8 years ago

That was purely to mirror the way you have, for example, scalaSource and javaSource exposed as individual settings - derived from sourceDirectory by default, but there to be overridden individually.

I was under the impression that scalaSource was also defined in compile but not in Global, am I mistaken? I'll investigate.

If you're not happy with the setting being exposed, I'll amend the commit accordingly.

jrudolph commented 8 years ago

Ah, I see. I agree this makes sense.

nrinaudo commented 8 years ago

I believe these new commits address your issues: watchSources now behaves as you'd expect, and packageSrc includes the generated sources. Let me know if I forgot anything.

jrudolph commented 8 years ago

I squashed your changes and commited them. Thanks, again, @nrinaudo!