search

sbt / sbt-boilerplate

sbt plugin for generating scala.Tuple/Function related boilerplate code
BSD 2-Clause "Simplified" License
109 stars 20 forks source link

Parser parses and alters regions outside [#....#] #3

Closed marklister closed 10 years ago

marklister commented 11 years ago

If I have a Template like this:

/** Thingy1 through 22 do blah blah blah */

[# Thingy1 #]

Then scaladoc part gets parsed as a LiteralString and then winds up getting mangled into /** Thingy22 through 223 do blah blah blah */

Ideally we don't want any alteration of the template file except between [# and #]

This made a bit of a mess of my source; enough that a pull request to fix this is on its way...

jrudolph commented 11 years ago

Aren't you interested in those changes any more or do you have no hope that I will ever merge them? :)

marklister commented 11 years ago

I saw that there's a clash with the rudimentary test code and the stuff you merged the other day. I was thinking to do a single clean PR rebased against 0.5.1. But if you think it's OK like this I'll reopen?

jrudolph commented 11 years ago

Ah, I think you closed both the PRs and the issues. Feel free to keep the issues open while you are working on the new PR. I'll try to integrate it this time.

marklister commented 11 years ago

Done!