sbt / sbt-ci-release

sbt plugin to automate Sonatype releases from GitHub Actions
Apache License 2.0
286 stars 76 forks source link

Support for Sonatype Central #294

Closed KacperFKorban closed 3 months ago

KacperFKorban commented 8 months ago

It seems that Sonatype's Jira is being deprecated in favour of Sonatype Central. (docs) The intention is to make Sonatype Central the main/only way to publish artifacts. It would be great to be able to publish to Sonatype Central using sbt-ci-release

There already exists a PR with the support for Sonatype Central API in sbt-sonatype: https://github.com/xerial/sbt-sonatype/pull/474

Andrapyre commented 8 months ago

Refactoring here should be very minimal, once sbt-sonatype has a new release, as the current implementation in this PR supports running sonatypeBundleRelease to deploy artifacts to Sonatype Central.

Sonatype Central does not support publishing snapshots however, so any logic around snapshot publication will need to be refactored, but that, again, looks very minimal.

KacperFKorban commented 8 months ago

Refactoring here should be very minimal, once sbt-sonatype has a new release, as the current implementation in https://github.com/xerial/sbt-sonatype/pull/474 supports running sonatypeBundleRelease to deploy artifacts to Sonatype Central.

@Andrapyre I thought as much. I think that the sbt-ci-release documentation might require the most changes. It is linked in many other repositories and is considered a "Scala Sonatype publishing source of truth".

BTW, thanks for implementing https://github.com/xerial/sbt-sonatype/pull/474 :heart:

Andrapyre commented 8 months ago

Good point about reproducing sonatype docs here, though I also don't see that requiring much investment, as the current implementation just requires users to change the sonatype host in order for everything to work out of the box.

xuwei-k commented 5 months ago
eed3si9n commented 3 months ago

https://github.com/sbt/sbt-ci-release/pull/303 landed, but given https://github.com/xerial/sbt-sonatype/issues/507 we might need to update.

mbaechler commented 2 months ago

Good point about reproducing sonatype docs here, though I also don't see that requiring much investment, as the current implementation just requires users to change the sonatype host in order for everything to work out of the box.

Hi @Andrapyre, I'm trying to make use of sbt-ci-release to publish my lib and I may not understand what you mean by

requires users to change the sonatype host in order for everything to work out of the box

Are you referring to something like

ThisBuild / sonatypeCredentialHost := sonatypeCentralHost

Maybe I did a stupid mistake but I can't make it work, I always get "Repository for publishing is not specified."

For reference, the project is here https://github.com/PerformanceIMMO/pg-event-store and the failing publish logs are here https://github.com/PerformanceIMMO/pg-event-store/actions/runs/10847421290/job/30102632825

Thanks for your help.

Andrapyre commented 2 months ago

@mbaechler , the link is coming up as not found for some reason. Is this a private repo?

mbaechler commented 2 months ago

@Andrapyre yes, sorry, it was private by mistake.