sbt / sbt-ci-release

sbt plugin to automate Sonatype releases from GitHub Actions
Apache License 2.0
286 stars 76 forks source link

Update sbt-sonatype to 3.11.0 #298

Closed scala-steward closed 3 months ago

scala-steward commented 4 months ago

About this PR

📦 Updates org.xerial.sbt:sbt-sonatype from 3.9.21 to 3.11.0

📜 GitHub Release Notes - Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

âš™ Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" } }] ```

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

KacperFKorban commented 4 months ago

@eed3si9n Could we get this PR merged and released? It should include support for publishing to Sonatype Central

tgodzik commented 4 months ago

Does this transitively introduce Zio dependency just for JSON decoding? Could we use Contraband / sjson-new that are already in use for sbt or uPickle instead?

Looks like it might take a while to update since there are two repositories down the line. @KacperFKorban will start working on PRs with the changes, but not sure when they will be merged and released. What do you say about merging this one as is @eed3si9n and improving the dependency situation later on. Looks like the situation is rather dire as no new accounts are able to release with this plugin.

eed3si9n commented 4 months ago

sbt-ci-release just bundles a bunch of plugins. If some users want to try the new sbt-sonatype they can opt in manually, no?

tgodzik commented 4 months ago

sbt-ci-release just bundles a bunch of plugins. If some users want to try the new sbt-sonatype they can opt in manually, no?

That's probably an option yeah, but does introduce an additional step in an already complicated process.

Adding:

addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.11.0")

alongside this plugin should override the default plugin version, right?

eed3si9n commented 4 months ago

Yea. Coursier runs for metabuild (plugin library dependencies), so it should just pick the latest one.

scala-steward commented 3 months ago

Superseded by #302.