sbt / sbt-eclipse

Plugin for sbt to create Eclipse project definitions
Apache License 2.0
716 stars 168 forks source link

Xmax-classfile-name should be put in scala.compiler.additionalParams #210

Open rpiotrow opened 10 years ago

rpiotrow commented 10 years ago

As I see in current (3.0.3) and upcoming (4.0.0 M2) versions of scala-ide plugin for eclipse there is no "Xmax-classfile-name" option in Preferences > Scala > Compilier. In that case I think this option should go to scala.compiler.additionalParams in org.scala-ide.sdt.core.prefs file not as separate option as it is now. I test that when it is as separate option scala-ide ignores it. It works when it is added to scala.compiler.additionalParams.

I think the change should be done in com.typesafe.sbteclipse.core.EclipseSDTConfig.scala: remove line "TakesArg("Xmax-classfile-name"),"

twothirdscyft commented 8 years ago

I'm on 4.0.0 and this is still an issue. @rpiotrow is correct in that 'max-classfile-name' needs to be added to scala.compiler.additionalParams