Update lots of things - Githubissues

sbt / sbt-findbugs

FindBugs static analysis plugin for sbt.

Eclipse Public License 1.0

46 stars 13 forks source link

Update lots of things #5

Closed anishathalye closed 10 years ago

anishathalye commented 10 years ago

Fix / clean up a bunch of stuff:

fix bugs and typos in documentation
update to findbugs 2.0.3
rename 'Effort' to 'Priority' to reflect meaning
add actual 'Effort' setting (that follows findbugs definition of effort)
make Priority and Effort enums type safe
clean up stuff in general

anishathalye commented 10 years ago

Also, we could convert all files from dos line endings to unix line endings. I did this, but didn't include the change in this pull request in case someone didn't want it.

The commit can be added by doing something like git fetch https://github.com/anishathalye/findbugs4sbt lineendings:lineendings and then a git merge --ff-only lineendings.

anishathalye commented 10 years ago

Also, if this pull request is merged, then commit 198b320 should be tagged 1.3.0.

jmhofer commented 10 years ago

Thanks! I'll take a look at this as soon as I'm back from my business trip.

anishathalye commented 10 years ago

One last thing, after merge this could also be published to Maven.

anishathalye commented 10 years ago

Hey there @jmhofer , just checking in to see if you've had a chance to look at this yet.

jmhofer commented 10 years ago

I took a look, it's all good, thanks a lot!

I'll convert line endings as you proposed, merge, and release.

jmhofer commented 10 years ago

Have to do this later, though, as I don't have my keys for publishing here.

anishathalye commented 10 years ago

Okay, thanks!