search

sbt / sbt-fmpp

FreeMarker Scala/Java Templating Plugin for SBT
Apache License 2.0
9 stars 8 forks source link

Fixed plugin for windows users #3

Closed rjean-gilles closed 11 years ago

rjean-gilles commented 11 years ago

The plugin was not working on windows: path separator on windows is ";" rather than ":".

aloiscochard commented 11 years ago

Thanks for the fix!

BTW, I would recommend to configure your text editor to not replace new line character when you edit a file. Actually I can't merge it like this, because you replaced all new line character by windows version.

I know VIM handle that well, but I'm pretty sure this can be configured in any text-editor :)

Encore merci!

rjean-gilles commented 11 years ago

Oops, sorry for that. I didn't notice anything fishy because apparently my git client ignore newline differences. And to be honest I have no idea if the change was done by IntelliJ or Notepad++, and in any case I can't find the related option.

2012/12/6 Alois Cochard notifications@github.com

Thanks for the fix!

BTW, I would recommend to configure your text editor to not replace new line character when you edit a file. Actually I can't merge it like this, because you replaced all new line character by windows version.

I know VIM handle that well, but I'm pretty sure this can be configured in any text-editor :)

Encore merci!

— Reply to this email directly or view it on GitHubhttps://github.com/aloiscochard/xsbt-fmpp-plugin/pull/3#issuecomment-11082781.

aloiscochard commented 11 years ago

Yeah you are right, it should be the job of git client to deal with this, and not the editor: https://help.github.com/articles/dealing-with-line-endings

Maybe it's only github which doesn't deal with that correctly, or a config mismatch between the git-client you used to preview vs the one to commit.

Any way, really not a big deal, just wanted to make you aware of that :)

I'll try to merge the fix and release a new version this weekend, or next week.

Cheers

rjean-gilles commented 11 years ago

Great, thanks.

2012/12/6 Alois Cochard notifications@github.com

Yeah you are right, it should be the job of git client to deal with this, and not the editor: https://help.github.com/articles/dealing-with-line-endings

Maybe it's only github which doesn't deal with that correctly, or a config mismatch between the git-client you used to preview vs the one to commit.

Any way, really not a big deal, just wanted to make you aware of that :)

I'll try to merge the fix and release a new version this weekend, or next week.

Cheers

— Reply to this email directly or view it on GitHubhttps://github.com/aloiscochard/xsbt-fmpp-plugin/pull/3#issuecomment-11089568.