search

sbt / sbt-ghpages

git, site and ghpages support for sbt projects.
Other
91 stars 20 forks source link

Don't delete files in the staged repository when synchronizing #3

Closed etorreborre closed 9 years ago

etorreborre commented 12 years ago

The documentation says that the push task must not remove the existing files in the staged repository (because the clean site task allows to do that), then I think that this line should be removed from the synchLocal task.

Review on Reviewable

jsuereth commented 12 years ago

(A) this can't be auto merged ideas?

(B) would you prefer to manually clean the site all the time? I "fixed" that without updating the docs... I actually quite like the current behavior.

etorreborre commented 12 years ago

(A) no, no idea

(B) my use case is the following. I have a gh-pages website containing generated files for: the current official version, the SNAPSHOT version. When I use sbt with my current development branch, if I generate the SNAPSHOT documentation I want to be able to push it without removing the existing official documentation. This is why removing everything before a push is problematic for me.

jsuereth commented 12 years ago

Ahhhh.... good call. If it's automergeable I'll take it now, otherwise when I can fully context switch my current task I'll do this next. On May 24, 2012 7:23 AM, "etorreborre" < reply@reply.github.com> wrote:

(A) no, no idea

(B) my use case is the following. I have a gh-pages website containing generated files for: the current official version, the SNAPSHOT version. When I use sbt with my current development branch, if I generate the SNAPSHOT documentation I want to be able to push it without removing the existing official documentation. This is why removing everything before a push is problematic for me.

Reply to this email directly or view it on GitHub: https://github.com/sbt/sbt-ghpages-plugin/pull/3#issuecomment-5897816