search

sbt / sbt-github-actions

An sbt plugin which makes it easier to build with GitHub Actions
Apache License 2.0
194 stars 59 forks source link

clean.yml doesn't respect githubWorkflowOSes #159

Closed custommonkey closed 12 months ago

custommonkey commented 1 year ago

clean.yml doesn't respect runs-on condition set in githubWorkflowOSes, hard coded value of ubuntu-latest may not work in hosted environments.

mdedetrich commented 1 year ago

So I started some work on this at https://github.com/sbt/sbt-github-actions/pull/167 however it will take some time to finish off due to the fact that the current clean.yml script is not portable for windows (even when running under Windows bash there appears to be some issues).

mdedetrich commented 1 year ago

Red herring, PR is ready just need someone else to review it

mdedetrich commented 12 months ago

@custommonkey v0.18.0 was just released with this feature added, can you please confirm that it works?

custommonkey commented 11 months ago

Thank you very much for this. clean is working as I expected.

I have noticed that the publish phase doesn't use the configured OS I hope submitted a PR to address this when I get some time.

mdedetrich commented 11 months ago

Thank you very much for this. clean is working as I expected.

I have noticed that the publish phase doesn't use the configured OS I hope submitted a PR to address this when I get some time.

Is the reason behind why publishes phase is not working due to the shell script not running or something else?

custommonkey commented 11 months ago

The WorkflowJob for publish doesn't use githubWorkflowOSes to set oses in the same way as the build step does. So the default value from WorkflowJob is used.

mdedetrich commented 11 months ago

@custommonkey PR created at https://github.com/sbt/sbt-github-actions/pull/169 . Ill ping you when its released and merged.

mdedetrich commented 11 months ago

@custommonkey v0.19.0 was just released with this fix, let me know if there are any additional issues.

custommonkey commented 11 months ago

Thanks that's working. I now have a separate issue that the v4 of the the checkout action isn't compatible with our enterprise version.

mdedetrich commented 11 months ago

Thanks that's working. I now have a separate issue that the v4 of the the checkout action isn't compatible with our enterprise version.

Hmm I am on the fence on this one, sounds like its a problem for github enterprise and/or checkout action to solve, no?

custommonkey commented 11 months ago

Yep