sbt / sbt-jacoco

an sbt plugin for JaCoCo Code Coverage
https://scala-sbt.org/sbt-jacoco/
Eclipse Public License 1.0
123 stars 67 forks source link

New release for JaCoCo 0.8.11 adding JDK 21 support #289

Closed ane closed 6 months ago

ane commented 10 months ago

Java 21 LTS was released on September 19th, 2023. Support for it in JaCoCo was added in version 0.8.11, and looks like the version is already correct in sbt-jacoco, all that's missing is someone pushing a new version to Sonatype Nexus.

Harish247 commented 9 months ago

Hi there! I'm currently working on a project that aims to leverage the new features and improvements introduced in Java 21. I noticed that this package is having compatibility issues. Any information on the ETA for this issue? Thank you for your efforts in maintaining this package and supporting the community!

DrSatyr commented 7 months ago

Seems Jacoco just turned off JDK 21 support in the current version (see PR https://github.com/jacoco/jacoco/pull/1433/files) due to an issue in Scala: https://github.com/jacoco/jacoco/issues/1431

We need to wait for a fix in a further version of Jacoco.

Godin commented 6 months ago

@DrSatyr JDK 21 is supported since JaCoCo 0.8.11 - see https://www.jacoco.org/jacoco/trunk/doc/changes.html

We need to wait for a fix in a further version of Jacoco

There is nothing to fix in JaCoCo, because https://github.com/jacoco/jacoco/issues/1431 is about bug in Scala compiler.

Seems Jacoco just turned off JDK 21 support in the current version (see PR https://github.com/jacoco/jacoco/pull/1433/files)

And https://github.com/jacoco/jacoco/pull/1433/files does not turn off JDK 21 support in JaCoCo.

jxnu-liguobin commented 6 months ago

What state about this issue?

eed3si9n commented 6 months ago

I don't use this plugin or send PRs, but apparently I've been the person cutting a release, so I'm doing it now.

eed3si9n commented 6 months ago

Release failed (https://github.com/sbt/sbt-jacoco/actions/runs/8250879513/job/22566565806), but something I can fix.

eed3si9n commented 6 months ago

Released https://github.com/sbt/sbt-jacoco/releases/tag/v3.5.0