search

sbt / sbt-jcstress

Trust no-one, and especially not memory visibility.
http://kto.so
19 stars 6 forks source link

Remove hardcoded paths in sbt task #1

Open ktoso opened 7 years ago

jiminhsieh commented 6 years ago

I think I could give it a shot. But I don't have any idea of how it should be like. I mean how user sends path to sbt-jcstress.

Or there is a better way to do it.

ktoso commented 6 years ago

just normal settings (sbt "setting key") IMHO, since users can override it

jiminhsieh commented 6 years ago

I think I need some clarification on this ticket. Which part of hardcoded path is?

Thanks! :)

jiminhsieh commented 6 years ago

BTW, I already tried to implement this one locally.

The path of result folder - I guess it would be better to let users override it.

I am not so sure which one is for this ticket. I guess I were doing this too rushed...

ktoso commented 6 years ago

I guess it was about The path of result folder - I guess it would be better to let users override it.

I'm also not really sure :) If you think it makes sense please PR

ktoso commented 6 years ago

Have not had much time to maintain this plugin...

jiminhsieh commented 6 years ago

Have not had much time to maintain this plugin...

I can relate to that. If there are any little things I could help or contribute, I am going to do my best. :)

I will send the PR latter.

ktoso commented 6 years ago

Thanks :)