search

sbt / sbt-jshint

Allows jslint to be used from within sbt. Builds on com.typesafe:webdriver in order to execute jslint.js along with the scripts to verify
Other
21 stars 20 forks source link

outdated jshint #34

Closed mberndt123 closed 7 years ago

mberndt123 commented 8 years ago

Hey,

The jshint version sbt-jshint uses (2.4.1) is outdated, the current version is 2.9.2. Just bumping the dependency version didn't seem to work as it doesn't find the lodash library, even if I add it as an additional dependency. How does sbt-jshint know which webjars to unpack anyway? Because it worked fine back when jshint was using underscore rather than lodash…

benmccann commented 8 years ago

I just merged a PR to bump it to 2.6.3-2

genachka commented 8 years ago

+1 to update to newer 2.9.2 version.

huntc commented 8 years ago

Are there massive benefits to upgrade at this point? Jshint is working great for me as-is.

genachka commented 8 years ago

From brief skim of the change log there's lots of bug fixes and much better ES6 support.

huntc commented 8 years ago

If someone can do the PR then I will review/merge/release.

koppor commented 8 years ago

In #36 I discovered the same issue as @mberndt123 (see https://travis-ci.org/sbt/sbt-jshint/builds/160997285)

No idea how to solve.

info] [info] Done updating.

[info] [info] JavaScript linting on 1 source(s)

[info] [error] 

[info] [error] module.js:340

[info] [error]     throw err;

[info] [error]           ^

[info] [error] Error: Cannot find module './scope-manager.js'

[info] [error]     at Function.Module._resolveFilename (module.js:338:15)

[info] [error]     at Function.Module._load (module.js:280:25)

[info] [error]     at Module.require (module.js:364:17)

[info] [error]     at require (module.js:380:17)

[info] [error]     at Object.<anonymous> (/tmp/sbt_4fe3dbc7/test/project/target/node-modules/webjars/jshint/src/jshint.js:44:20)
koppor commented 8 years ago

I updated jshint from jshint-node to jshint and all tests go through in #31. Maybe someone else can double check?

benmccann commented 7 years ago

Currently using "org.webjars.npm" % "jshint" % "2.9.3"