search

sbt / sbt-launcher-package

Packaging for sbt so you can run it.
http://scala-sbt.org/download.html
Apache License 2.0
89 stars 92 forks source link

Add special handling for -XX #306

Closed michaelh0911 closed 5 years ago

michaelh0911 commented 5 years ago

Add special handling for -XX Fix special handling for -D where > null should be > nul Fix the problem that only the first option of SBT_OPTS and JAVA_OPTS got processed

eed3si9n commented 5 years ago

@michaelh0911 Thanks for the contribution. Could you add some tests for these things here https://github.com/sbt/sbt-launcher-package/blob/master/integration-test/src/test/scala/RunnerTest.scala?

er1c commented 5 years ago

@michaelh0911 just wanted to say thanks again for digging into this contribution!

eed3si9n commented 5 years ago

I'm in Greece this week for Lightbend meetings, but I'll try to get a release out once I'm back next week.

er1c commented 5 years ago

@michaelh0911 🎉 🎊 Thank you again for this contribution and willingness to problem solve it!