search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.6k stars 441 forks source link

docker: make None the last layer group #1370

Closed pawitp closed 4 years ago

pawitp commented 4 years ago

Currently, if a user adds additional artifact to the Docker build without modifying dockerGroupLayers, the artifact will have "None" grouping and be put as the first layer in the output.

These additional artifacts are often configuration or supporting assets. Making this the zeroth layer by default causes dependency layer to not be re-used if any of these artifacts are changed.

Since not all users will care to modify dockerGroupLayers, the default should be to make it such that adding additional artifact does not break re-use of the dependency layer.

lightbend-cla-validator commented 4 years ago

Hi @pawitp,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

muuki88 commented 4 years ago

1.7.6 is on its way