sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.6k stars 441 forks source link

Move some defaults of docker to global scope #1403

Closed swsnr closed 3 years ago

swsnr commented 3 years ago

SBT strongly recommends to use the global scope for default settings, see https://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html#Provide+default+values+in

This allows to set the docker image and common labels once in ThisBuild for all subprojects, and makes it easier to use a different docker-compatible container builder by overriding the command, e.g.

sbt 'set ThisBuild / dockerExecCommand := Seq("podman")' docker:publish
lightbend-cla-validator commented 3 years ago

Hi @lunaryorn,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

swsnr commented 3 years ago

I should like to point out that while I am fairly confident that this works I didn't test it, because I'm admittedly too lazy to bother with publishing locally and adding it to a project :grimacing:

muuki88 commented 3 years ago

1.8.1 is being released

swsnr commented 3 years ago

Thank you.