search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.6k stars 441 forks source link

bump scala-parser-combinators to 2.0.0 #1442

Closed arw357 closed 3 years ago

lightbend-cla-validator commented 3 years ago

Hi @arw357,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

mkurz commented 3 years ago

@muuki88 We need that merged and released so we can upgrade scala-parser-combinators in Play: https://github.com/playframework/playframework/pull/10901

muuki88 commented 3 years ago

Sure sure 😃 will push a release later

mkurz commented 3 years ago

Actually merging this pull request was a mistake: sbt-native packager is a sbt-plugin. sbt-plugins get published for Scala 2.12. The 2.12.x scala compiler depends on 1.x versions for both scala-parser-combinators and scala-xml, see https://github.com/scala/scala/blob/2.12.x/versions.properties#L21-L22 If we would use 2.x versions, we would run into annoying dependency conflicts in sbt 1.5+ There is no need to upgrade these versions to 2.x, the only reason would be if we would cross build for Scala 3, but sbt-plugins do not need to be cross build for Scala 3.

See discussion in https://github.com/scala/scala/pull/9743