Fixes for argument handling in AshScriptPlugin's script template

sbt / sbt-native-packager

sbt Native Packager

BSD 2-Clause "Simplified" License

1.6k stars 441 forks source link

Open kevinmehall opened 3 years ago

kevinmehall commented 3 years ago

Previously the -main argument was ignored because the custom_mainclass variable was set but never used. process_args is called after app_mainclass is set to the default value, so this PR makes it simply overwrite app_mainclass instead of introducing another variable.
Previously the additional arguments passed on the command line were passed to java before the defaults, which means the defaults take precedence and couldn't be overridden. This puts the flags from JAVA_OPTS and the command line after the defaults, which matches the behavior of the Bash template.

lightbend-cla-validator commented 3 years ago

Hi @kevinmehall,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

lightbend-cla-validator commented 3 years ago

Hi @kevinmehall,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

muuki88 commented 3 years ago

Can you sign the Contributor CLA?

lightbend-cla-validator commented 3 years ago

Hi @kevinmehall,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: