search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.59k stars 437 forks source link

True Multi OS support with `pathSeparator` #1522

Closed Rojods closed 1 year ago

Rojods commented 1 year ago

The previous version had the ":" hard-coded as a module-path separator, which might be fine on Linux(es) and Macs, but fails on Windows. I suggest we simply put File.pathSeparator instead and rely on the JVM to tell us the right path separator character. Then there is also less burden on this project to keep the path separator code up-to-date.

lightbend-cla-validator commented 1 year ago

Hi @Rojods,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Rojods commented 1 year ago

I am just writing here to say I've signed the CLA.

muuki88 commented 1 year ago

Thanks a lot for your contribution ☺️