search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.59k stars 437 forks source link

Fixes #1345 - do not buffer logging for native-image output #1540

Closed nikolaylagutko closed 1 year ago

nikolaylagutko commented 1 year ago

Replace default BufferedLogger implementation of ProcessLogger with custom implementation that does not bufferize output - so the stdout of Process come to log immediately, but not at the Process exit

lightbend-cla-validator commented 1 year ago

Hi @nikolaylagutko,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

nikolaylagutko commented 1 year ago

@muuki88 the log is here, but it had printed output only when native-image command finished. As my build takes few minutes - it's much pretty to see the some log lines with process to be sure it working :-D More detailed can be found here #1345