search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.59k stars 437 forks source link

Fixes #1542 - GraalVMNativeImagePlugin ignores resources in src/graal #1543

Closed heaven-born closed 1 year ago

heaven-born commented 1 year ago

Fixes #1542

lightbend-cla-validator commented 1 year ago

Hi @heaven-born,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

heaven-born commented 1 year ago

I signed the CLA

heaven-born commented 1 year ago

Doesn't look like Universal / mappings has any effect on GraalVMNativeImagePlugin, but I tried just in case, and it didn't work out. But even if it did, it wouldn't be the way as it is documented in https://www.scala-sbt.org/sbt-native-packager/formats/graalvm-native-image.html :

If you are building the image in a docker container, and you have any resources that need to be available to the native-image command, such as files passed to -H:ResourceConfigurationFiles or -H:ReflectionConfigurationFiles, you can place these in your projects src/graal directory. Any files in there will be made available to the native-image docker container under the path /opt/graalvm/stage/resources.

Currently, all resources placed in src/graal directory are not accessible for -H:ResourceConfigurationFiles and -H:ReflectionConfigurationFiles, because /opt/graalvm/stage/resources is not in classpath.

heaven-born commented 1 year ago

I signed the CLA, should I restart the build somehow to make this check pass now?

muuki88 commented 1 year ago

I'll release ASAP

muuki88 commented 1 year ago

Version 1.9.17 is on it's way

heaven-born commented 11 months ago

looks like something went wrong with the build