sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.59k stars 437 forks source link

Corrected typo #1562

Closed Seetaramayya closed 3 months ago

Seetaramayya commented 7 months ago

Initially, this PR was created to investigate whether #1557 was the cause of the build failures. It was determined that #1557 was not the root cause. Upon further investigation, two main issues were identified:

  1. In a multi-stage Dockerfile, the LABEL command should appear after the second stage to label the stages correctly, as noted in this Stack Overflow comment: Stack Overflow Link.

  2. To ensure a successful build, intermediate images labeled with snp-multi-stage=intermediate were removed.

I'm curious about how the build was previously successful (or) Did I miss something?

Seetaramayya commented 7 months ago

@muuki88 Could you kindly help me understand how the builds were successful previously?

In this PR, a small change from scripted-graavlvm: to scripted-graalvm: in the GitHub workflows resulted in a failure. Although it appeared minor, it unexpectedly impacted the docker and GraalVM test cases. I've made adjustments to resolve these issues.

When I attempt to use the provided Dockerfile content, I encounter an error during the docker build process: Error reading component list: https://oca.opensource.oracle.com/gds/meta-data.json. I'm puzzled a bit as to why the issue arises with the published image

Dockerfile

FROM ghcr.io/graalvm/graalvm-ce:22.0.0.2
WORKDIR /opt/graalvm
RUN ["gu", "install", "native-image"]
RUN ["sh", "-c", "ln -s /opt/graalvm-ce-*/bin/native-image /usr/local/bin/native-image"]
ENTRYPOINT ["native-image"]
muuki88 commented 3 months ago

Hi @Seetaramayya

Thanks for the ping and your patience :pray: Can you check if this change is still needed? There has been some recent changes by @mkurz and @dwickern to solve the build issues.

Seetaramayya commented 3 months ago

Sorry for the late response, I'll role back my changes except typo (graalvm), if the build is successful then everything is good

Seetaramayya commented 3 months ago

It would be nice to change checks of master to correct typo. Of course it does not matter.

I opened this PR to check all the checks are passing or not. Builds are passing 🕺