search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.59k stars 437 forks source link

Windows bat script improvements #1563

Closed dwickern closed 5 months ago

dwickern commented 7 months ago

There are still some things missing for complete parity with the bash script but this gets us a little closer.

Fixes parsing of -J-XX: options containing an equal sign

I'm using the same logic as sbt's own launcher. Unless it starts with -XX:+ or -XX:-, all -XX: options are parsed as two arguments

Fixes #1387 Fixes #1090

Note that if you're using the workaround from #1387 by quoting the options in application.ini, that will no longer work.

Implements -java-home option

Used like -java-home "C:\Program Files\Eclipse Adoptium\jre-11.0.13.8-hotspot" or -java-home "%APP_HOME%\jre". The argument has higher priority than environment variables.

Fixes #1447 Fixes #1070

lightbend-cla-validator commented 7 months ago

Hi @dwickern,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

http://www.lightbend.com/contribute/cla

muuki88 commented 5 months ago

Thanks a lot @dwickern . The test failures seem unrelated. I guess GraalVM & Docker need constant maintenance. Thus I merged your change for the time being