search

sbt / sbt-native-packager

sbt Native Packager
https://sbt-native-packager.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
1.59k stars 437 forks source link

DockerPlugin publishTask: switch --push flag to --output=type=registry #1564

Closed zachdecook closed 7 months ago

zachdecook commented 7 months ago

--push is shorthand for --output=type=registry (https://docs.docker.com/engine/reference/commandline/buildx_build/#push)

By specifying --output=type=registry, sbt can support when docker is a symlink to podman.

lightbend-cla-validator commented 7 months ago

Hi @zachdecook,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

zachdecook commented 7 months ago

This is incorrect. (it fixes a symptom of the problem, but podman requires a second command to be run to push it).

Probably it's best fixed by patching podman.