search

sbt / sbt-osgi

sbt plugin for creating OSGi bundles
Apache License 2.0
47 stars 43 forks source link

Include jars from fullClassPath if they aren't initially calculated #103

Open mdedetrich opened 8 months ago

mdedetrich commented 8 months ago

Resolves: https://github.com/sbt/sbt-osgi/issues/102

Implements this solution

At least on a glance to me it seems like a quick way to fix this is to combine both (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value and (fullClasspath in Compile) but use (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value as a preference which should still solve the underlying problem described in https://github.com/sbt/sbt-osgi/issues/60 .

mdedetrich commented 8 months ago

So this PR is failing to pass because the scripted test test-05-exportJars is stalling. test-10-multi-project-dependsOn-includePackage-versions is passing since there aren't any extra jars in (fullClasspath in Compile) that isn't contained within (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value

mdedetrich commented 8 months ago

Blocked by https://github.com/sbt/sbt-osgi/issues/104